msokolov commented on code in PR #13469:
URL: https://github.com/apache/lucene/pull/13469#discussion_r1633432342
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99ScalarQuantizedVectorsReader.java:
##########
@@ -189,6 +191,18 @@ public ByteVectorValues getByteVectorValues(String field)
throws IOException {
return rawVectorsReader.getByteVectorValues(field);
}
+ @Override
Review Comment:
I did toy with adding a "supportsSearch" flag when this problem surfaced due
to BaseKnnVectorsFormatTestCase. Potentially we could return no results. I feel
like this is the moral equivalent of a stored Field with IndexOptions.NONE
(Like StoredField.TYPE)? But we have tended to not want to make such
vector-representation choices a part of the Fields API, so it looks different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
