benwtrent commented on code in PR #13469:
URL: https://github.com/apache/lucene/pull/13469#discussion_r1633378674
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99ScalarQuantizedVectorsReader.java:
##########
@@ -189,6 +191,18 @@ public ByteVectorValues getByteVectorValues(String field)
throws IOException {
return rawVectorsReader.getByteVectorValues(field);
}
+ @Override
Review Comment:
So, doing this means the `KnnFloatVectorQuery` will throw an error if its
used against a field with a codec using this reader.
Traditionally, query's were fairly ignorant of the underlying codec used to
store the field.
It does seem weird to have a codec that the Knn queries could be executed
against throw an exception.
I think either:
- The knn queries should automatically do the correct things (e.g. not
eagerly rewrite themselves, etc.)
- We don't throw on `search` like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
