rmuir commented on PR #13707: URL: https://github.com/apache/lucene/pull/13707#issuecomment-2325046919
I feel like with this code there are only two options: * keep `isTotal` O(1) , to prevent traps and problems. it does document that the input must be minimized. Maybe it is enough to fix our regexp parser on another issue so that typical use cases of the method (optimizing) get optimized. * change `isTotal` to O(n^2) using the code here. Add warnings about this. Remove usage from CompiledAutomaton so at least we don't cause internal performance problems because of it. a third option: `isTotal` that runs faster than O(n^2), would be awesome :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
