rmuir commented on PR #13707: URL: https://github.com/apache/lucene/pull/13707#issuecomment-2325299722
ok, the tests have found all the fun with empty cases and I think it is ready for review. for background, this problem is similar to `Operations.isEmpty()`: https://github.com/apache/lucene/blob/5b125f305048d6d10905b19987f8c6f10c5dbe99/lucene/core/src/java/org/apache/lucene/util/automaton/Operations.java#L821-L858 to keep it simple, for `Operations.isTotal()` here we call `getLiveStates()` up-front and then just work every state individually. alternatively we could avoid that, and "traverse" automaton to look more like `Operations.isEmpty()` logic. but I think at least as a start, using `getLiveStates()` is easier to reason about. Either way you'd need a BitSet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
