stefanvodita commented on code in PR #13723:
URL: https://github.com/apache/lucene/pull/13723#discussion_r1754952420
##########
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetAssociations.java:
##########
@@ -654,7 +654,7 @@ private void assertFloatFacetResultsEqual(List<FacetResult>
expected, List<Facet
assertEquals(expectedResult.dim, actualResult.dim);
assertArrayEquals(expectedResult.path, actualResult.path);
- assertEquals((float) expectedResult.value, (float) actualResult.value,
2e-1);
+ assertUlpEquals((float) expectedResult.value, (float)
actualResult.value, (short) 2);
Review Comment:
It's correct in the sense that it's the smallest value that will pass the
test that was failing. Is it the smallest value that will pass this test on any
seed? That I'm not sure. I've run 500 iterations and didn't see the test fail
again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
