mikemccand commented on PR #13723: URL: https://github.com/apache/lucene/pull/13723#issuecomment-2348502055
> > I don't like the last commit because it changes from a assert-like method to a boolean returning method. > > I changed it away from an assertion because I liked this more. It makes it so you can assert on floats _not_ being equal or use their equality in a condition, without making an assertion statement much longer. Do you not like it because it's too generic? We could move it to `TestUtil` or we could provide assertion methods alongside the equality methods, if that helps. Maybe we could do both? I.e. add the `TestUtil` boolean-returning methods (`float/doubleEquals`) to `TestUtil` but then also add the sugar methods `void assertFloat/DoubleUlpEquals`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
