uschindler commented on code in PR #13723:
URL: https://github.com/apache/lucene/pull/13723#discussion_r1759155851
##########
lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java:
##########
@@ -864,6 +864,14 @@ public static void assumeNoException(String msg, Exception
e) {
RandomizedTest.assumeNoException(msg, e);
}
+ public static void assertFloatUlpEquals(final float x, final float y, final
short maxUlps) {
+ assertTrue(TestUtil.floatUlpEquals(x, y, maxUlps));
Review Comment:
Maybe add a message showing string of both values.
The problem with assert true is that you get no useful output.
This is why I wanted to have the assert methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
