gmarouli opened a new pull request, #15727: URL: https://github.com/apache/lucene/pull/15727
### Description **Problem** `ToParentBlockJoinSortField` did not handle missing values for child documents. When a parent had a mix of children with a value and children without, the children without values were silently ignored from the min/max selection. This led to incorrect sort ordering -- the missing children should participate in the comparison using a configurable missing value, consistent with how the missing value in `SortField` works. Additionally, the parent-level `missingValue` which was not configurable after #15483, is reinstated and configurable via the constructor. **Plan** - Add support for `missingValue` configuration for the parent-level in `ToParentBlockJoinSortField` making it again configurable. - Rename the ambiguous `reverse` and `order` flags in the constructor of `ToParentBlockJoinSortField`. - Add support for `missingValue` configuration for the child-level in `ToParentBlockJoinSortField` and extend `ToParentDocValues` and `BlockJoinSelector` to detect children with missing values and incorporate the configurable missing value into the min/max aggregation, with proper handling for all supported types. Fixes #15548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
