gmarouli commented on code in PR #15727:
URL: https://github.com/apache/lucene/pull/15727#discussion_r2838351512
##########
lucene/join/src/java/org/apache/lucene/search/join/ToParentDocValues.java:
##########
@@ -205,22 +253,28 @@ public int nextDoc() throws IOException {
return docID;
}
- assert parents.get(childWithValues.docID()) == false;
+ seen = false;
+ while (seen == false) {
+ assert parents.get(childWithValues.docID()) == false;
- int nextParentDocID = parents.nextSetBit(childWithValues.docID());
- collector.reset();
- seen = true;
+ int nextParentDocID = parents.nextSetBit(childWithValues.docID());
Review Comment:
Thank you for spotting it! It should have been in the loop. Fixed and test
added, I added a new one dedicated to `nextDoc` because of its complexity, but
if you think it would be better to add it to the existing one I can do it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
