gmarouli commented on code in PR #15727:
URL: https://github.com/apache/lucene/pull/15727#discussion_r2832554950
##########
lucene/join/src/java/org/apache/lucene/search/join/ToParentDocValues.java:
##########
@@ -176,22 +196,38 @@ public long cost() {
private ToParentDocValues(
DocIdSetIterator values, BitSet parents, DocIdSetIterator children,
Accumulator collect) {
+ this(values, parents, children, false, collect);
+ }
+
+ private ToParentDocValues(
+ DocIdSetIterator values,
+ BitSet parents,
+ DocIdSetIterator children,
+ boolean missingWithChildWithoutValue,
+ Accumulator collect) {
this.parents = parents;
childWithValues =
ConjunctionUtils.intersectIterators(Arrays.asList(children, values));
this.collector = collect;
+ this.missingWithChildWithoutValue = missingWithChildWithoutValue;
Review Comment:
100%, I wasn't super happy with it either...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
