ChrisHegarty commented on code in PR #16418:
URL: https://github.com/apache/lucene/pull/16418#discussion_r3673103340
##########
lucene/core/src/java/org/apache/lucene/index/ReadersAndUpdates.java:
##########
@@ -325,6 +342,70 @@ private synchronized void handleDVUpdates(
final IOContext updatesContext = IOContext.flush(new
FlushInfo(info.info.maxDoc(), bytes));
final FieldInfo fieldInfo = infos.fieldInfo(field);
assert fieldInfo != null;
+ // The field's current overlay {baseGen, deltas...} (or null). baseGen
is the recorded base
+ // once the field has
+ // deltas, otherwise the field's current column (-1 = core, or an
earlier dense generation).
Review Comment:
trivially just reflow the comment text.
##########
lucene/luke/src/java/org/apache/lucene/luke/models/util/IndexUtils.java:
##########
@@ -350,8 +350,10 @@ protected String doBody(String segmentFileName) throws
IOException {
format = "Lucene 7.4 or later";
} else if (actualVersion == SegmentInfos.VERSION_86) {
format = "Lucene 8.6 or later";
- } else if (actualVersion > SegmentInfos.VERSION_86) {
- format = "Lucene 8.6 or later (UNSUPPORTED)";
+ } else if (actualVersion == SegmentInfos.VERSION_11_0) {
Review Comment:
Are you planning to backport this to 10.6? Should the version be encoded as
VERSION_10_6?
##########
lucene/core/src/java/org/apache/lucene/index/SegmentCommitInfo.java:
##########
@@ -71,6 +71,11 @@ public class SegmentCommitInfo {
// Track the per-field DocValues update files
private final Map<Integer, Set<String>> dvUpdatesFiles = new HashMap<>();
+ // Per-field sparse doc-values overlay: field number -> {baseGen,
deltaGenNewestFirst...} (baseGen
+ // -1 = the core
+ // column). Absent for a field using the classic single-generation column.
Review Comment:
minor: comment flow, as the new line here makes the comment a bit awkward to
read. `baseGen - 1` is a sentinel value.
##########
lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java:
##########
@@ -118,7 +126,10 @@ public final class SegmentInfos implements Cloneable,
Iterable<SegmentCommitInfo
/** The version that recorded SegmentCommitInfo IDs */
public static final int VERSION_86 = 10;
- static final int VERSION_CURRENT = VERSION_86;
+ /** The version that records per-field incremental doc-values overlay
generations. */
+ public static final int VERSION_11_0 = 11;
Review Comment:
Are you planning to backport this to 10.6? Should the version be encoded as
VERSION_10_6?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
