uschindler commented on PR #16371: URL: https://github.com/apache/lucene/pull/16371#issuecomment-5117972528
> > Looks good now! Maybe also update the regnerated files in the analysis-common module. I have no seen an update here, although ICU dependency was updated. Maybe it was done already (see comment above). > > I checked main branch, the UnicodeProps.java file has newest ICU version in the header. Looks like this one was already updated. We should really have some automatic check! Automatic check works, it was just not applied due to wrongly named task. This is fixed now after renaming everything to `regenerate*`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
