uschindler commented on code in PR #16371:
URL: https://github.com/apache/lucene/pull/16371#discussion_r3672319008
##########
lucene/analysis/icu/build.gradle:
##########
@@ -284,7 +284,7 @@ configure(project(":lucene:analysis:common")) {
configure(project(":lucene:core")) {
setupIcuDependencies(project)
- tasks.register("generateUnicodeProps", {
+ tasks.register("generateCaseFolding", {
Review Comment:
I checked
`build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/regenerate/RegenerateTasksSupportPlugin.java`.
It should normally add a dependency to the `check` task, so when running
`gradlew check` it should complain about not yet regenerated files. Not sure
why this never worked. Maybe only the checksum of the source file is taken into
account, and nt the ICU version, although it appears in the dependency file.
@dweiss?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
