uschindler commented on code in PR #16371:
URL: https://github.com/apache/lucene/pull/16371#discussion_r3673205789
##########
lucene/analysis/icu/build.gradle:
##########
@@ -284,7 +284,7 @@ configure(project(":lucene:analysis:common")) {
configure(project(":lucene:core")) {
setupIcuDependencies(project)
- tasks.register("generateUnicodeProps", {
+ tasks.register("generateCaseFolding", {
Review Comment:
I think I know what's wrong: In main branch the task had wrong name:
https://github.com/apache/lucene/blob/04d33b4ce5dd9f0466ce7b525c3ef5a770925eb2/lucene/analysis/icu/build.gradle#L287
So the regeneration plugin does not track the version of files and
depenendecies, because it only looks for tsasks that start match
`"^regenerate.+"`. This is why it wasn't updated after ICU version changed.
So all looks fine now. The bug was fixed by renaming the tasks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
