jimczi commented on code in PR #16418:
URL: https://github.com/apache/lucene/pull/16418#discussion_r3677114226
##########
lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java:
##########
@@ -118,7 +126,10 @@ public final class SegmentInfos implements Cloneable,
Iterable<SegmentCommitInfo
/** The version that recorded SegmentCommitInfo IDs */
public static final int VERSION_86 = 10;
- static final int VERSION_CURRENT = VERSION_86;
+ /** The version that records per-field incremental doc-values overlay
generations. */
+ public static final int VERSION_11_0 = 11;
Review Comment:
Just the name, not the value: the fence is the value (11), which is higher
than VERSION_86 so an older reader rejects it either way. On main it is
VERSION_11_0 since main is 11.0. If/when we backport to 10.6 I would rename it
to VERSION_10_6 (value unchanged), a trivial rename on both branches. So I
would rather defer the naming to the actual backport.
##########
lucene/luke/src/java/org/apache/lucene/luke/models/util/IndexUtils.java:
##########
@@ -350,8 +350,10 @@ protected String doBody(String segmentFileName) throws
IOException {
format = "Lucene 7.4 or later";
} else if (actualVersion == SegmentInfos.VERSION_86) {
format = "Lucene 8.6 or later";
- } else if (actualVersion > SegmentInfos.VERSION_86) {
- format = "Lucene 8.6 or later (UNSUPPORTED)";
+ } else if (actualVersion == SegmentInfos.VERSION_11_0) {
Review Comment:
Same as the note on the version constant: it is just naming, the value is 11
regardless. I would rename to VERSION_10_6 if/when we backport, deferring it
until then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
