jimczi commented on code in PR #16418:
URL: https://github.com/apache/lucene/pull/16418#discussion_r3677214985
##########
lucene/core/src/java/org/apache/lucene/index/ReadersAndUpdates.java:
##########
@@ -325,6 +342,70 @@ private synchronized void handleDVUpdates(
final IOContext updatesContext = IOContext.flush(new
FlushInfo(info.info.maxDoc(), bytes));
final FieldInfo fieldInfo = infos.fieldInfo(field);
assert fieldInfo != null;
+ // The field's current overlay {baseGen, deltas...} (or null). baseGen
is the recorded base
+ // once the field has
+ // deltas, otherwise the field's current column (-1 = core, or an
earlier dense generation).
Review Comment:
Done, reflowed.
##########
lucene/core/src/java/org/apache/lucene/index/SegmentCommitInfo.java:
##########
@@ -71,6 +71,11 @@ public class SegmentCommitInfo {
// Track the per-field DocValues update files
private final Map<Integer, Set<String>> dvUpdatesFiles = new HashMap<>();
+ // Per-field sparse doc-values overlay: field number -> {baseGen,
deltaGenNewestFirst...} (baseGen
+ // -1 = the core
+ // column). Absent for a field using the classic single-generation column.
Review Comment:
Done, reflowed and called out that a baseGen of -1 is the sentinel for the
core column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
