eolivelli commented on a change in pull request #38: [MSHADE-350] enable to rewrite the manifest URL: https://github.com/apache/maven-shade-plugin/pull/38#discussion_r375940070
########## File path: src/main/java/org/apache/maven/plugins/shade/resource/ManifestResourceTransformer.java ########## @@ -51,6 +51,8 @@ // Fields private boolean manifestDiscovered; + private boolean skipRelocators; Review comment: it looks like you are never setting a value ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services