rmannibucau commented on a change in pull request #38: [MSHADE-350] enable to
rewrite the manifest
URL: https://github.com/apache/maven-shade-plugin/pull/38#discussion_r376223734
##########
File path:
src/main/java/org/apache/maven/plugins/shade/resource/ManifestResourceTransformer.java
##########
@@ -46,6 +46,8 @@
// Configuration
private String mainClass;
+ private boolean skipRelocators;
Review comment:
Hmm, sounds like an option but current code works well for jakarta
relocation too so I'm mixed to make the conf more complex/verbose for end user.
Is having the boolean AND dedicated relocators ok for you? Boolean could be
reversed and named "inheritDefaultRelocators".
Wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
