rmannibucau commented on a change in pull request #38: [MSHADE-350] enable to
rewrite the manifest
URL: https://github.com/apache/maven-shade-plugin/pull/38#discussion_r376068006
##########
File path:
src/main/java/org/apache/maven/plugins/shade/resource/ManifestResourceTransformer.java
##########
@@ -46,6 +46,8 @@
// Configuration
private String mainClass;
+ private boolean skipRelocators;
Review comment:
Agree but the algorithm being a bit fragile until we use a full osgi header
parsers/rewriter with exception algorithms for the general case, I'd prefer a
parameter to disable it for not osgi case. I can enhance the parsing but
thought it is not the core of shade plugin so is kot worse that logic. If
wrong, happy to revise this.
Not perfect state but secured - would be sad to break a project for that new
behavior IMHO.
Wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
