rfscholte commented on issue #38: [MSHADE-350] enable to rewrite the manifest URL: https://github.com/apache/maven-shade-plugin/pull/38#issuecomment-583418806 We shouldn't try to make things bigger than necessary. You provided a test (brilliant) with known OSGi attributes. After the patch the test succeeds. Does it require extra effort and customization from the user? No. Can we extend it when required? Sure, either by increasing the list of known attributes or giving the ability to specify this list. But we should only do the latter if we can't solve it with known attributes anymore. If you also want to support custom attributes, you should add a test based on a realworld example. (you could decide to put that in a new ticket)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
