rfscholte commented on a change in pull request #38: [MSHADE-350] enable to
rewrite the manifest
URL: https://github.com/apache/maven-shade-plugin/pull/38#discussion_r376268714
##########
File path:
src/main/java/org/apache/maven/plugins/shade/resource/ManifestResourceTransformer.java
##########
@@ -46,6 +46,8 @@
// Configuration
private String mainClass;
+ private boolean skipRelocators;
Review comment:
Once a skip parameter is introduced, it is very hard to get rid of it, so
I'll try to block it when possible(it is not a common practice as many users
use as argument, it is just a lazy hack). The enduser shouldn't notice the
difference. I'm also working on the maven-shade-plugin, so I'll give it a try
as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
