Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605484137
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -1560,6 +1566,18 @@ private void convertGroupParameters()
}
}
+ private void convertJunitEngineParameters()
+ {
+ if ( this.getJunitIncludeEngine() != null )
+ {
+ getProperties().setProperty(
ProviderParameterNames.JUNIT_INCLUDE_ENGINE_PROP, this.getJunitIncludeEngine()
);
+ }
+ if ( this.getJunitExcludeEngine() != null )
+ {
+ getProperties().setProperty(
ProviderParameterNames.JUNIT_EXCLUDE_ENGINE_PROP, this.getJunitExcludeEngine()
);
Review comment:
Here can be the static import for the constant JUNIT_EXCLUDE_ENGINE_PROP
and the line would become shorter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
