Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605533224
##########
File path:
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
##########
@@ -766,6 +768,72 @@ public void
tagExpressionsAreSupportedForIncludeTagsContainingAmpersand()
assertEquals( 2, provider.getFilters().length );
}
+ @Test
+ public void onlyJunitIncludeEngineIsDeclared()
+ {
+ Map<String, String> properties = singletonMap(
JUNIT_INCLUDE_ENGINE_PROP, "engine-one, engine-two" );
+
+ ProviderParameters providerParameters = providerParametersMock(
TestClass1.class );
+ when( providerParameters.getProviderProperties() ).thenReturn(
properties );
+
+ JUnitPlatformProvider provider = new JUnitPlatformProvider(
providerParameters );
+
+ assertEquals( 1, provider.getFilters().length );
Review comment:
`instanceOf` would be fine too.
Dont use assertEquals, you have more modern style, see `import static
org.assertj.core.api.Assertions.assertThat`
Example:
`assertThat( provider.getFilters() ).hasSize( 1 )`
`assertThat( provider.getFilters() ).element( 0 ).isInstanceOf(
TestEngine.class )`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
