Tibor17 commented on a change in pull request #344:
URL: https://github.com/apache/maven-surefire/pull/344#discussion_r605488089
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -1560,6 +1566,18 @@ private void convertGroupParameters()
}
}
+ private void convertJunitEngineParameters()
+ {
+ if ( this.getJunitIncludeEngine() != null )
Review comment:
I think this class is using `isNotBlank` somewhere too. It is in one of
the classes `StringUtils`/ It is very useful because it has the same meaning
for `not` and empty strings or strings having white spaces, since they do not
cover any reasonable value, and the method returns `false` in these cases.
Same in the second IF below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
