sman-81 commented on code in PR #157:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/157#discussion_r957270247
##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -6081,7 +6081,25 @@ && isJavadocVMInitError( output ) )
msg.append( exitCode );
if ( StringUtils.isNotEmpty( err.getOutput() ) )
{
- msg.append( " - " ).append( err.getOutput() );
+ // parse stderr, log informational output, add all other
to exception message
+ List<String> nonInfoLines = new ArrayList<>();
+ for ( String str : err.getOutput().split( "\\R" ) )
+ {
+ if ( isInfoOutput( str ) )
+ {
+ getLog().debug( str );
Review Comment:
The method was named `isInfoOutput` in the sense of: is informational (e.g.
not error) output of the Javadoc tool.
The mojo logs at debug and info levels in various places. It's a matter of
taste whether the output identified by `isInfoOutput` should be logged at debug
or info level. I am open to whichever. The naming of the method lets one expect
that it should be logged as `info`, so I understand why you would ask the
question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
