sman-81 commented on code in PR #157:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/157#discussion_r960748864
##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -6144,6 +6171,23 @@ private boolean containsWarnings( String output )
}
}
+ /**
+ * Determines whether the specified string is informational output of the
Javadoc tool.
+ *
+ * @param str string to check
+ * @return true if informational output, false if not or cannot be
determined
+ */
+ private boolean isInfoOutput( String str )
+ {
+ return str == null
Review Comment:
A null string should not go to the non-informational output therefore it is
considered informational. The null check is also to ensure the following
statements will never cause NPE.
You are right, I should include empty and blank strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
