sman-81 commented on code in PR #157:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/157#discussion_r957353580
##########
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##########
@@ -6144,6 +6171,23 @@ private boolean containsWarnings( String output )
}
}
+ /**
+ * Determines whether the specified string is informational output of the
Javadoc tool.
+ *
+ * @param str string to check
+ * @return true if informational output, false if not or cannot be
determined
+ */
+ private boolean isInfoOutput( String str )
+ {
+ return str == null
+ || str.startsWith( "Loading source file " )
+ || str.startsWith( "Generating " )
+ || str.startsWith( "Constructing Javadoc information" )
+ || str.startsWith( "Building index for " )
+ || str.startsWith( "Building tree for " )
+ || str.startsWith( "Standard Doclet version " );
+ }
Review Comment:
I dug further into this. The Javadoc tool has localizations for Japanese and
Chinese only it seems.
Found in AdoptOpenJDK / openjdk-jdk11u:
https://github.com/AdoptOpenJDK/openjdk-jdk11u/tree/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources
So for those two my PR won't do anything, the plugin will behave just as
before. The implementation is defensive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
