[
https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697929#comment-17697929
]
Romain Manni-Bucau commented on MNG-7724:
-----------------------------------------
> One more time: if a project chooses to fail on *warnings* that's there issue,
> not ours. We should not adjust our code to suit their idiosyncratic code
> bureaucracy.
> It sounds like maybe this shouldn't log at all. That is, this issue is simply
> not a problem. The code runs fine. If so, turn it off completely. But if it
> is a problem, then make it a warning, not info.
You just ignore the context, as explained in the issue there are multiple
contexts and therefore outcome/expectations:
# I wouldn't call users idots because they don't do like you do (it is often
the opposite actually, we learn from users), technically speaking out
fail-on-severity is likely the most idiot part of the solution ;)
# it is a warning if maven intends to use a predefined integration but fails
to do so
# it is an info if maven has no integration - but fail-on-severity will be
disabled which is intended when doing this kind of setup
# a warning is only relevant if you can do something about it and here it
implies coding which is not satisfying for any CI solution - the PR solves that
# Also strongly disagree that failling on warning is an user issue and not a
maven one, you can check out some project even encouraging it like...maven
(fail-on-severity is exactly that case) so no, your statement is likely wrong
or maven toggle is wrong, I'm fine with both options but we need a solution
anyway.
So overall I think the PR enables all the mentionned use cases smoothly even if
I agree with your the slf4j binding integration is likely wrong from a design
standpoint (think of the case where slf4j falls back on noop, the warning will
not be seen at all for ex).
> Don't log warnings when runtime is not broken (slf4j integrations)
> ------------------------------------------------------------------
>
> Key: MNG-7724
> URL: https://issues.apache.org/jira/browse/MNG-7724
> Project: Maven
> Issue Type: Improvement
> Affects Versions: 4.0.0-alpha-4
> Reporter: Romain Manni-Bucau
> Priority: Minor
>
> As of now if we change the SLF4J bindings maven will issue warnings because a
> few features are disabled but due to the nature of switching these bindings
> it is highly likely it is intended and therefore the warning are misleading
> more than helping.
> The solution can be to log a warning if a configured factory fails to load
> but just log info when it succeeds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
