[ https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697909#comment-17697909 ]
ASF GitHub Bot commented on MNG-7724: ------------------------------------- rmannibucau commented on code in PR #1041: URL: https://github.com/apache/maven/pull/1041#discussion_r1129441351 ########## maven-embedder/pom.xml: ########## @@ -140,6 +140,12 @@ under the License. <artifactId>slf4j-simple</artifactId> <optional>true</optional> </dependency> + <dependency> + <groupId>org.slf4j</groupId> + <artifactId>slf4j-jdk14</artifactId> Review Comment: 14 = 1.4, code is from 2006 ;) > Don't log warnings when runtime is not broken (slf4j integrations) > ------------------------------------------------------------------ > > Key: MNG-7724 > URL: https://issues.apache.org/jira/browse/MNG-7724 > Project: Maven > Issue Type: Improvement > Affects Versions: 4.0.0-alpha-4 > Reporter: Romain Manni-Bucau > Priority: Minor > > As of now if we change the SLF4J bindings maven will issue warnings because a > few features are disabled but due to the nature of switching these bindings > it is highly likely it is intended and therefore the warning are misleading > more than helping. > The solution can be to log a warning if a configured factory fails to load > but just log info when it succeeds. -- This message was sent by Atlassian Jira (v8.20.10#820010)