[ 
https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697985#comment-17697985
 ] 

Romain Manni-Bucau commented on MNG-7724:
-----------------------------------------

> Warnings are warnings and not errors for a reason.

Does not change the fact the log is at a bothering level (warning = call for 
action but does not block, whereas error = you failed). It is still wrong and 
in such cases it is fair to ask the project emitting it to fix its logic 
instead of just configuring an ignore pattern which can lead to ignoring an 
actual action message.

> Also we shouldn't call ex.printStackTrace in 
> Slf4jConfigurationFactory.getConfigurationFactory. The catch block maybe 
> should log a warning (though that's a potentially different warning than 
> we're logging now, and more actionable). Or perhaps this should be at debug 
> level? But UnsupportedSlf4jBindingConfiguration should not log anything.

Was what was doing my previous PR and logging in info the fact the maven 
integration was not there for the case there was no exception but this option 
was rejected.

Technically speaking the exception logging must *not* use a logger since when 
it happens it can mean the logging setup is broken.

> Don't log warnings when runtime is not broken (slf4j integrations)
> ------------------------------------------------------------------
>
>                 Key: MNG-7724
>                 URL: https://issues.apache.org/jira/browse/MNG-7724
>             Project: Maven
>          Issue Type: Improvement
>    Affects Versions: 4.0.0-alpha-4
>            Reporter: Romain Manni-Bucau
>            Priority: Minor
>
> As of now if we change the SLF4J bindings maven will issue warnings because a 
> few features are disabled but due to the nature of switching these bindings 
> it is highly likely it is intended and therefore the warning are misleading 
> more than helping.
> The solution can be to log a warning if a configured factory fails to load 
> but just log info when it succeeds.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to