[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802250#comment-17802250
 ] 

ASF GitHub Bot commented on DOXIASITETOOLS-323:
-----------------------------------------------

kwin commented on code in PR #125:
URL: 
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440639693


##########
doxia-integration-tools/pom.xml:
##########
@@ -86,9 +86,15 @@
       <scope>provided</scope>
     </dependency>
     <dependency>
-      <groupId>org.apache.maven</groupId>
-      <artifactId>maven-plugin-api</artifactId>
-      <version>${mavenVersion}</version>
+      <groupId>org.eclipse.aether</groupId>
+      <artifactId>aether-api</artifactId>
+      <version>${aetherVersion}</version>
+      <scope>provided</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.eclipse.aether</groupId>
+      <artifactId>aether-impl</artifactId>

Review Comment:
   It is a transitive dependency of `maven-core` and `maven-aether-provider` 
(the latter also being a transitive dependency of maven-core). I don't know how 
the 
<https://maven.apache.org/plugins/maven-dependency-plugin/analyze-mojo.htm>l 
with https://maven.apache.org/shared/maven-dependency-analyzer/ concludes that 
this is necessary (couldn't bring it to log the referencing class) but IMHO it 
isn't. @michael-o Any idea how to make the output of m-dependency-p more 
verbose in this regard?





> Upgrade components
> ------------------
>
>                 Key: DOXIASITETOOLS-323
>                 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323
>             Project: Maven Doxia Sitetools
>          Issue Type: Dependency upgrade
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 2.0.0, 2.0.0-M17
>
>
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Plexus Testing 1.3.0
> * Upgrade to Plexus Velocity 2.1.0
> * Upgrade to Commons Lang 3.14.0
> * Upgrade to Commons IO 2.15.1
> * Upgrade to JUnit 5.10.1



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to