[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802319#comment-17802319
]
ASF GitHub Bot commented on DOXIASITETOOLS-323:
-----------------------------------------------
kwin commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440916439
##########
doxia-integration-tools/pom.xml:
##########
@@ -86,9 +86,15 @@
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>org.apache.maven</groupId>
- <artifactId>maven-plugin-api</artifactId>
- <version>${mavenVersion}</version>
+ <groupId>org.eclipse.aether</groupId>
+ <artifactId>aether-api</artifactId>
+ <version>${aetherVersion}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.aether</groupId>
+ <artifactId>aether-impl</artifactId>
Review Comment:
To make m-dependency-p work correctly and to reduce the (compile) classpath
of this module itself (it won’t have an effect on referencing projects as you
noticed correctly). I consider this best practice given that Maven < 4 lacks a
proper API artifact.
> Upgrade components
> ------------------
>
> Key: DOXIASITETOOLS-323
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 2.0.0, 2.0.0-M17
>
>
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Plexus Testing 1.3.0
> * Upgrade to Plexus Velocity 2.1.0
> * Upgrade to Commons Lang 3.14.0
> * Upgrade to Commons IO 2.15.1
> * Upgrade to JUnit 5.10.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
