[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802309#comment-17802309
]
ASF GitHub Bot commented on DOXIASITETOOLS-323:
-----------------------------------------------
michael-o commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440867789
##########
doxia-integration-tools/pom.xml:
##########
@@ -86,9 +86,15 @@
<scope>provided</scope>
</dependency>
<dependency>
- <groupId>org.apache.maven</groupId>
- <artifactId>maven-plugin-api</artifactId>
- <version>${mavenVersion}</version>
+ <groupId>org.eclipse.aether</groupId>
+ <artifactId>aether-api</artifactId>
+ <version>${aetherVersion}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.eclipse.aether</groupId>
+ <artifactId>aether-impl</artifactId>
Review Comment:
I see this and `maven-core` is in `provided` scope, why should we exclude
all deps? Moreover, we don't exclude in other components. I don't fully
understand the reasoning.
Tree:
```
[INFO] +- org.apache.maven:maven-core:jar:3.2.5:provided
[INFO] | +- org.apache.maven:maven-settings:jar:3.2.5:provided
[INFO] | +- org.apache.maven:maven-settings-builder:jar:3.2.5:provided
[INFO] | +- org.apache.maven:maven-repository-metadata:jar:3.2.5:provided
[INFO] | +- org.apache.maven:maven-plugin-api:jar:3.2.5:provided
[INFO] | +- org.apache.maven:maven-model-builder:jar:3.2.5:provided
[INFO] | +- org.eclipse.aether:aether-util:jar:1.0.0.v20140518:provided
[INFO] | +- org.sonatype.sisu:sisu-guice:jar:no_aop:3.2.3:provided
[INFO] | +- org.codehaus.plexus:plexus-classworlds:jar:2.5.2:compile
[INFO] | +-
org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile
[INFO] | \- org.sonatype.plexus:plexus-sec-dispatcher:jar:1.3:provided
[INFO] | \- org.sonatype.plexus:plexus-cipher:jar:1.4:provided
```
> Upgrade components
> ------------------
>
> Key: DOXIASITETOOLS-323
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 2.0.0, 2.0.0-M17
>
>
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Plexus Testing 1.3.0
> * Upgrade to Plexus Velocity 2.1.0
> * Upgrade to Commons Lang 3.14.0
> * Upgrade to Commons IO 2.15.1
> * Upgrade to JUnit 5.10.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
