[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802257#comment-17802257 ]
ASF GitHub Bot commented on DOXIASITETOOLS-323: ----------------------------------------------- kwin commented on code in PR #125: URL: https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440651510 ########## doxia-integration-tools/pom.xml: ########## @@ -86,9 +86,15 @@ <scope>provided</scope> </dependency> <dependency> - <groupId>org.apache.maven</groupId> - <artifactId>maven-plugin-api</artifactId> - <version>${mavenVersion}</version> + <groupId>org.eclipse.aether</groupId> + <artifactId>aether-api</artifactId> + <version>${aetherVersion}</version> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>org.eclipse.aether</groupId> + <artifactId>aether-impl</artifactId> Review Comment: The funny thing is that once you exclude those transitive deps, the m-dependency-p does not longer deem them necessary. For testing they are indeed necessary (due to references in `SiteToolTest`. For me the pom.xml works like this ``` ... <dependency> <groupId>org.apache.maven</groupId> <artifactId>maven-core</artifactId> <version>${mavenVersion}</version> <scope>provided</scope> <exclusions> <exclusion> <groupId>*</groupId> <artifactId>*</artifactId> </exclusion> </exclusions> </dependency> <dependency> <groupId>org.apache.maven</groupId> <artifactId>maven-compat</artifactId> <version>${mavenVersion}</version> <scope>provided</scope> </dependency> <dependency> <groupId>org.apache.maven</groupId> <artifactId>maven-model</artifactId> <version>${mavenVersion}</version> <scope>provided</scope> </dependency> <dependency> <groupId>org.eclipse.aether</groupId> <artifactId>aether-api</artifactId> <version>${aetherVersion}</version> <scope>provided</scope> </dependency> <! > Upgrade components > ------------------ > > Key: DOXIASITETOOLS-323 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade > Reporter: Michael Osipov > Assignee: Michael Osipov > Priority: Major > Fix For: 2.0.0, 2.0.0-M17 > > > * Upgrade to Plexus Interpolation 1.27 > * Upgrade to Plexus Testing 1.3.0 > * Upgrade to Plexus Velocity 2.1.0 > * Upgrade to Commons Lang 3.14.0 > * Upgrade to Commons IO 2.15.1 > * Upgrade to JUnit 5.10.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)