rmannibucau commented on code in PR #200: URL: https://github.com/apache/maven-compiler-plugin/pull/200#discussion_r1497418122
########## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ########## @@ -279,8 +279,11 @@ public abstract class AbstractCompilerMojo extends AbstractMojo { * <ul> * <li><code>none</code> - no annotation processing is performed.</li> * <li><code>only</code> - only annotation processing is done, no compilation.</li> + * <li><code>full</code> - annotation processing and compilation.</li> * </ul> * + * <code>full</code> is the default. Starting with JDK 21, this option must be set explicitly. Review Comment: well issue is that `full` got backported to several lower versions too so I don't think we can write something relevant so ensuring we do the two passes when there is at least one SPI file sounds more robust until proc:none is set in the configuration (either `proc` or `compilerArgs`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org