kwin commented on code in PR #200:
URL:
https://github.com/apache/maven-compiler-plugin/pull/200#discussion_r1512962253
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -279,8 +279,11 @@ public abstract class AbstractCompilerMojo extends
AbstractMojo {
* <ul>
* <li><code>none</code> - no annotation processing is performed.</li>
* <li><code>only</code> - only annotation processing is done, no
compilation.</li>
+ * <li><code>full</code> - annotation processing and compilation.</li>
* </ul>
*
+ * <code>full</code> is the default. Starting with JDK 21, this option
must be set explicitly.
Review Comment:
We can use conditions depending on the javac version (as we currently do in
https://github.com/codehaus-plexus/plexus-compiler/blob/d8e98dda661b2e976f5382d43bb87dea1434381f/plexus-compilers/plexus-compiler-javac/src/main/java/org/codehaus/plexus/compiler/javac/JavacCompiler.java#L348).
But IMHO m-compiler-p should add a more high level abstraction, as other
compilers might handle that differently...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
