hgschmie commented on code in PR #200:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/200#discussion_r1512176374


##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -279,8 +279,11 @@ public abstract class AbstractCompilerMojo extends 
AbstractMojo {
      * <ul>
      * <li><code>none</code> - no annotation processing is performed.</li>
      * <li><code>only</code> - only annotation processing is done, no 
compilation.</li>
+     * <li><code>full</code> - annotation processing and compilation.</li>
      * </ul>
      *
+     * <code>full</code> is the default. Starting with JDK 21, this option 
must be set explicitly.

Review Comment:
   While it is great that this is forward ported to the latest versions of 8,11 
and 17, there is still the issue of people running with older versions of the 
JDK and can not change. So it would be nice to have a bit more logic in there. 
   
   @EwoutH I saw your comment; sorry I am pretty swamped right now to work on 
this change beyond this initial PR. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to