rmannibucau commented on code in PR #200: URL: https://github.com/apache/maven-compiler-plugin/pull/200#discussion_r1513223723
########## src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java: ########## @@ -279,8 +279,11 @@ public abstract class AbstractCompilerMojo extends AbstractMojo { * <ul> * <li><code>none</code> - no annotation processing is performed.</li> * <li><code>only</code> - only annotation processing is done, no compilation.</li> + * <li><code>full</code> - annotation processing and compilation.</li> * </ul> * + * <code>full</code> is the default. Starting with JDK 21, this option must be set explicitly. Review Comment: Hmm, shouldnt we revert the parent change? except it is a breaking change it is also unexpected IMHO. side note: this does not allow more than compilerArgs but enables to get conflicting args now ;). Agree with you @bmarwell if v4 arrives at ~the same time than v3.x+1 since 21 starts to be used and everybody creates the verbose way in the pom which is very unlikely IMHO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org