gnodet commented on PR #12694: URL: https://github.com/apache/maven/pull/12694#issuecomment-6360192196
@rmannibucau Thanks for the review — good design feedback. Addressed inline on each specific point. Summary of what I'll act on: 1. **`formattedMessage()` on the interface** → agreed it's a rendering concern, not data. Will remove from `LogEvent` interface and move to an injected `LogEventFormatter` in consumers (coordinating with #13180 before this becomes a shipped API). 2. **`Throwable` vs pre-formatted `stackTrace()`** → will add `default @Nullable Throwable throwable()` alongside `stackTrace()` for consumers that need the raw exception. 3. **Thread name capture** → will add `threadName()` populated at event-creation time in both `MavenJulHandler` and `ProjectBuildLogAppender`. 4. **Custom `LogManager` guard in `LookupInvoker`** → will add the guard (matching `SLF4JBridgeHandler`'s own defense) before touching JUL root handlers. 5. **`message()` as template+args** → keeping as substituted string for now (JUL path can't reconstruct the template after formatting); explained rationale inline. 6. **"Why not full JUL/LogRecord"** → Maven is SLF4J-first; routing SLF4J events through JUL would add overhead and lose marker/MDC data. Explained inline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
