rmannibucau commented on code in PR #12694:
URL: https://github.com/apache/maven/pull/12694#discussion_r4357392481
##########
impl/maven-logging/src/main/java/org/apache/maven/slf4j/MavenSimpleLogger.java:
##########
@@ -39,14 +39,90 @@ public class MavenSimpleLogger extends MavenBaseLogger {
private String warnRenderedLevel;
private String errorRenderedLevel;
Review Comment:
let's reverse the question then, if SLF4J is out impl (ack we don't expose
it in the api), then why not using slf4j as impl there and duplicating the
model? just trying to reduce the duplication layer, maven simple logger should
almost not exist at the end of the rework IMHO and only surface as plugin and
extension/services api, not impl bridge, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
