gnodet commented on code in PR #12694:
URL: https://github.com/apache/maven/pull/12694#discussion_r4357411702
##########
impl/maven-logging/src/main/java/org/apache/maven/slf4j/MavenSimpleLogger.java:
##########
@@ -39,14 +39,90 @@ public class MavenSimpleLogger extends MavenBaseLogger {
private String warnRenderedLevel;
private String errorRenderedLevel;
Review Comment:
Good question. exists because Maven is the SLF4J **provider** (not a
consumer): it implements and supplies its own . That gives us control over
every log call made by plugins and Maven itself — we can intercept at the
source, before any formatting happens, and route to directly.
If we used an off-the-shelf SLF4J backend (Logback, Log4j2, the simple
logger shipped with SLF4J) we'd have to either (a) configure it externally and
lose the ability to swap the sink at runtime, or (b) write our own backend
anyway — which is exactly what / are.
Long term the goal is for to do less: once the plugin / extension SPI
converges on (maven-api-core), internal Maven code will use it directly, and
can shrink to a thin SLF4J bridge. But that migration is a separate concern and
happens incrementally across the PR chain — worth opening a follow-up issue if
you'd like to track it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
