[ 
https://jira.codehaus.org/browse/MRELEASE-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319911#comment-319911
 ] 

Fred Cooke commented on MRELEASE-777:
-------------------------------------

Building twice seems to me to be necessary. The first pass is a "will it build 
OK" pass BEFORE committing the pom modifications. Without this you have to 
chance it, and roll back the commit if broken, which seems messy, even if done 
manually. I can see the chancing it thing being useful on a huge project, but I 
can't see any reason to have such a huge project in the first place, to be 
honest ;-) However it's certainly possible for it to be legit, whether yours is 
or not, and that should be enough to better support it. So my vote is for 
chancing it to be optional if at all possible.

I agree with your flow with one exception, clean -dxf, this is extremely 
dangerous and simply has to be an optional thing, if used at all. mvn clean 
should be sufficient, if not, your project seems to me to be broken. If you 
execute clean -dxf in some non-git sub-directory and have either your home dir 
or your root dir under git control with lots of stuff ignored, you're going to 
potentially nuke your entire account. Use with extreme caution. This IS a maven 
build, afterall.


                
> release plugin shouldn't git clone if the SCM is git
> ----------------------------------------------------
>
>                 Key: MRELEASE-777
>                 URL: https://jira.codehaus.org/browse/MRELEASE-777
>             Project: Maven 2.x Release Plugin
>          Issue Type: Improvement
>         Environment: Linux x86_64, maven 2.2.1
>            Reporter: Joel Orlina
>            Assignee: Mark Struberg
>
> See here for original issue:
> https://issues.sonatype.org/browse/MVNCENTRAL-202

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to