[
https://issues.apache.org/jira/browse/METRON-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673571#comment-16673571
]
ASF GitHub Bot commented on METRON-1853:
----------------------------------------
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1251#discussion_r230480258
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/StellarFunction.java
---
@@ -23,4 +23,5 @@
Object apply(List<Object> args, Context context) throws ParseException;
void initialize(Context context);
boolean isInitialized();
--- End diff --
if you are going to have a no parameter function, why not just implement
closable?
> Add shutdown hook to Stellar BaseFunctionResolver
> -------------------------------------------------
>
> Key: METRON-1853
> URL: https://issues.apache.org/jira/browse/METRON-1853
> Project: Metron
> Issue Type: Improvement
> Reporter: Michael Miklavcic
> Assignee: Michael Miklavcic
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
