[ 
https://issues.apache.org/jira/browse/METRON-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673714#comment-16673714
 ] 

ASF GitHub Bot commented on METRON-1853:
----------------------------------------

Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1251#discussion_r230517539
  
    --- Diff: 
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/FunctionResolver.java
 ---
    @@ -43,4 +45,11 @@
        * @param context Context used to initialize.
        */
       void initialize(Context context);
    +
    +  /**
    +   * Perform any cleanup necessary for the loaded Stellar functions.
    +   */
    --- End diff --
    
    I don't understand why the override here?  Did you mean to default?


> Add shutdown hook to Stellar BaseFunctionResolver
> -------------------------------------------------
>
>                 Key: METRON-1853
>                 URL: https://issues.apache.org/jira/browse/METRON-1853
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Michael Miklavcic
>            Assignee: Michael Miklavcic
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to