[ 
https://issues.apache.org/jira/browse/METRON-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674107#comment-16674107
 ] 

ASF GitHub Bot commented on METRON-1853:
----------------------------------------

Github user mmiklavc commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1251#discussion_r230560387
  
    --- Diff: 
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/BaseFunctionResolver.java
 ---
    @@ -94,6 +95,16 @@ public void initialize(Context context) {
         this.context = context;
       }
     
    +  /**
    +   * Close the Stellar functions.
    +   */
    +  @Override
    +  public void close() throws IOException {
    +    for (StellarFunctionInfo info : getFunctionInfo()) {
    --- End diff --
    
    On a related note, we may want to consider timeouts at some point, but we 
don't do this for initialization either.


> Add shutdown hook to Stellar BaseFunctionResolver
> -------------------------------------------------
>
>                 Key: METRON-1853
>                 URL: https://issues.apache.org/jira/browse/METRON-1853
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Michael Miklavcic
>            Assignee: Michael Miklavcic
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to