[
https://issues.apache.org/jira/browse/METRON-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673713#comment-16673713
]
ASF GitHub Bot commented on METRON-1853:
----------------------------------------
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1251#discussion_r230517250
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/BaseFunctionResolver.java
---
@@ -94,6 +95,16 @@ public void initialize(Context context) {
this.context = context;
}
+ /**
+ * Close the Stellar functions.
+ */
+ @Override
+ public void close() throws IOException {
+ for (StellarFunctionInfo info : getFunctionInfo()) {
--- End diff --
Should there be an "Attempt" to close each function? I think we want to
have a try catch for each call here maybe and just throw with the functions
that failed afterwards.
> Add shutdown hook to Stellar BaseFunctionResolver
> -------------------------------------------------
>
> Key: METRON-1853
> URL: https://issues.apache.org/jira/browse/METRON-1853
> Project: Metron
> Issue Type: Improvement
> Reporter: Michael Miklavcic
> Assignee: Michael Miklavcic
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
