mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r348189052
########## File path: metron-platform/metron-indexing/metron-indexing-common/src/test/java/org/apache/metron/indexing/dao/metaalert/MetaAlertIntegrationTest.java ########## @@ -584,9 +561,9 @@ public void addRemoveAlertsShouldThrowExceptionForInactiveMetaAlert() throws Exc try { metaDao.removeAlertsFromMetaAlert("meta_alert", Collections.singletonList(new GetRequest("message_0", SENSOR_NAME))); - Assert.fail("Removing alerts from an inactive meta alert should throw an exception"); + fail("Removing alerts from an inactive meta alert should throw an exception"); Review comment: Might be worth using the new idiom for exception testing here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services