mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to
JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r348188806
##########
File path:
metron-platform/metron-indexing/metron-indexing-common/src/test/java/org/apache/metron/indexing/dao/metaalert/MetaAlertIntegrationTest.java
##########
@@ -246,18 +223,18 @@ public void shouldSortByThreatTriageScore() throws
Exception {
srAsc.setSort(Collections.singletonList(sfAsc));
result = metaDao.search(srAsc);
results = result.getResults();
- Assert.assertEquals("message_1",
results.get((0)).getSource().get(Constants.GUID));
- Assert.assertEquals("meta_active_0",
results.get((1)).getSource().get(Constants.GUID));
- Assert.assertEquals(2, results.size());
+ assertEquals("message_1",
results.get((0)).getSource().get(Constants.GUID));
+ assertEquals("meta_active_0",
results.get((1)).getSource().get(Constants.GUID));
+ assertEquals(2, results.size());
}
@Test
public void getAllMetaAlertsForAlertShouldThrowExceptionForEmptyGuid()
throws Exception {
try {
metaDao.getAllMetaAlertsForAlert("");
- Assert.fail("An exception should be thrown for empty guid");
+ fail("An exception should be thrown for empty guid");
Review comment:
Might be worth using the new idiom for exception testing here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
