adamdebreceni commented on code in PR #1930:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1930#discussion_r2189529197
##########
extensions/standard-processors/processors/RouteText.cpp:
##########
@@ -61,14 +58,12 @@ void RouteText::onSchedule(core::ProcessContext& context,
core::ProcessSessionFa
const auto static_relationships = RouteText::Relationships;
std::vector<core::RelationshipDefinition>
relationships(static_relationships.begin(), static_relationships.end());
- for (const auto& property_name : getDynamicPropertyKeys()) {
+ for (const auto& property_name : context.getDynamicPropertyKeys()) {
core::RelationshipDefinition rel{property_name, "Dynamic Route"};
dynamic_relationships_[property_name] = rel;
relationships.push_back(rel);
logger_->log_info("RouteText registered dynamic route '{}'",
property_name);
}
-
- setSupportedRelationships(relationships);
Review Comment:
it did not really make sense to call setSupportedRelationships here since
the manifest is already populated with Class::Relationships and get/is
SupportedRelationships is not really used anywhere, but since it could be used
flow parse-time to verify a connection, I would not yet remove these methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
