adamdebreceni commented on code in PR #1930:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1930#discussion_r2213141520
##########
libminifi/include/core/FlowConfiguration.h:
##########
@@ -84,8 +84,7 @@ class FlowConfiguration : public CoreComponentImpl {
~FlowConfiguration() override;
// Create Processor (Node/Input/Output Port) based on the name
- std::unique_ptr<core::Processor> createProcessor(const std::string &name,
const utils::Identifier &uuid);
- std::unique_ptr<core::Processor> createProcessor(const std::string &name,
const std::string &fullname, const utils::Identifier &uuid);
+ std::unique_ptr<core::Processor> createProcessor(const std::string
&class_short, const std::string &fullclass, const std::string &name, const
utils::Identifier &uuid);
Review Comment:
even though the processor's name was available we did not forward it to the
constructor, instead the constructor was executed using the class's name as the
processor instance's name, so the parameters called `name` and `fullname` were
actually the class's short name and fully qualified name. As for why it needs
both, there is a fallback mechanism if the short name fails, and I did not want
to poke that part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
